Fix crash when user clicks on "Task Instance Details" caused by start_date being None #14416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqian90
requested review from
ashb,
kaxil,
turbaszek and
XD-DENG
as code owners
XD-DENG
reviewed
Feb 24, 2021
yuqian90
force-pushed
the
fix_none_date
branch
from
0b8e9ed
to
d8a9c72
Compare
kaxil
approved these changes
Feb 25, 2021
This was referenced Feb 26, 2021
Closed
ashb
pushed a commit
that referenced
this pull request
Mar 19, 2021
…_date being None (#14416) This is to fix the following error that happens when a user clicks on 'Task Instance Details' for a TaskInstance that has previous TaskInstance not yet run. E.g. The previous TaskInstance has not yet run because its dependencies are not yet met The previous TaskInstance has not yet run because scheduler is busy, the previous TaskInstance was marked success without running. This bug was caused by #12910. It affects Airflow 2.0.0 and 2.0.1. (cherry picked from commit 21f2974)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 1, 2021
…_date being None (apache#14416) This is to fix the following error that happens when a user clicks on 'Task Instance Details' for a TaskInstance that has previous TaskInstance not yet run. E.g. The previous TaskInstance has not yet run because its dependencies are not yet met The previous TaskInstance has not yet run because scheduler is busy, the previous TaskInstance was marked success without running. This bug was caused by apache#12910. It affects Airflow 2.0.0 and 2.0.1. (cherry picked from commit 21f2974) (cherry picked from commit 040f7d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the following error that happens when a user clicks on 'Task Instance Details' for a TaskInstance that has previous TaskInstance not yet run. E.g.
This bug was caused by #12910. It affects Airflow 2.0.0 and 2.0.1.